Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Check on logFn breaks on IE8 #5147

Closed
ghost opened this issue Nov 26, 2013 · 3 comments
Closed

Check on logFn breaks on IE8 #5147

ghost opened this issue Nov 26, 2013 · 3 comments
Assignees
@tbosch
Milestone
1.2.6

Comments

@ghost
Copy link

ghost commented Nov 26, 2013

On line 9153 of AngularJS 1.2.2 we have the following:

if (logFn.apply) {

this breaks on IE8 because logFn is just an empty object. To make it work it must be modified like this:

if (typeof logFn.apply === 'function' && logFn.apply) {

This works perfectly on all browsers.
@samturner
Copy link

I'm also having the same issue, but in Chrome 31.0.1650.57. I've applied the same fix and I'm still getting the error. By the way, this is on line 9187 of Angular 1.2.3.

@m0xb
Copy link

m0xb commented Dec 11, 2013

I am running into this issue using IE 11.0.9600.16428 with IE8 document mode.

This was referenced Dec 19, 2013
Closed
Closed
@ghost ghost assigned tbosch Dec 19, 2013
tbosch added a commit to tbosch/angular.js that referenced this issue Dec 19, 2013
@tbosch
fix($log): should work in IE8
96ffd38 
In IE8, reading `console.log.apply` throws an error.
Catching this errow now.

Fixes angular#5400. Fixes angular#5147.
@tbosch tbosch closed this as completed in 4f5758e Dec 19, 2013
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
@tbosch @jamesdaily
fix($log): should work in IE8
37da675 
In IE8, reading `console.log.apply` throws an error.
Catching this errow now.

Fixes angular#5400. Fixes angular#5147.
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
@tbosch @jamesdaily
fix($log): should work in IE8
28f3e34 
In IE8, reading `console.log.apply` throws an error.
Catching this errow now.

Fixes angular#5400. Fixes angular#5147.
@jdruiter
Copy link

apply method in general (without parentheses) also gives problems in IE8, please avoid it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tbosch tbosch

Labels
None yet
Projects
None yet
Milestone
1.2.6
Development

Successfully merging a pull request may close this issue.

Fix IE8 problems in $log and general startup tbosch/angular.js
4 participants
@samturner @tbosch @m0xb @jdruiter