Binding to "disabled" attribute fails on IE7/8 #351

idosela · 2011-05-25T21:09:34Z

The following markup will make the button enabled on Chrome/Firefox but not on IE:

<body ng:init="scope = { isDisabled: false }">

  <button disabled="{{scope.isDisabled}}">Disabled</button>

</body>

mhevery · 2011-05-25T22:45:04Z

This is a known issue, and I already have a fix for it in my private branch.

The issue is that the older browser do not preserve the value boolean attributes such as disabled. This prevents the angular compiler from correctly retrieving the binding expression. This is not a bug per say, but angular should have a good answer.

workaround

use ng:bind-attr

<body ng:init="scope = { isDisabled: false }">
  <button ng:bind-attr="{ disabled:'{{scope.isDisabled}}' }">Disabled</button>
</body>

proposed fix

prefix disabled with ng: to convert it into regular attribute.

<body ng:init="scope = { isDisabled: false }">
  <button ng:disabled="{{scope.isDisabled}}">Disabled</button>
</body>

psyho · 2011-05-26T13:43:13Z

I think the fix should look more like (to be consistent with ng:class, ng:click, etc.):

<body ng:init="scope = { isDisabled: false }">
  <button ng:disabled="scope.isDisabled">Disabled</button>
</body>

mhevery · 2011-05-26T16:34:50Z

@psyho

The ng:disabled should behave the same way as disabled (on non-ie browsers). Therefore the {{}} is needed. Similarly ng:href behaves same as href but it just does not make a bogus browser request. That way the developer can just add the ng: prefix.

IgorMinar · 2011-06-02T18:58:58Z

where is this fix? can it be merged into master?

mhevery · 2011-06-05T18:49:50Z

It is in a half baked CL. Here is the patch

src/markups.js

@@ -134,7 +134,10 @@ angularTextMarkup('option', function(text, textNode,
parentElement){

*/

var NG_BIND_ATTR = 'ng:bind-attr';

-var SPECIAL_ATTRS = {'ng:src': 'src', 'ng:href': 'href'};

+var SPECIAL_ATTRS = {};

+forEach(

'src,href,checked,disabled,multiple,readonly,selected'.split(','),
function(name){ SPECIAL_ATTRS['ng:' + name] = name; });

angularAttrMarkup('{{}}', function(value, name, element){

// don't process existing attribute markup

if (angularDirective(name) || angularDirective("@" + name)) return;

On Thu, Jun 2, 2011 at 11:58 AM, IgorMinar <
[email protected]>wrote:

where is this fix? can it be merged into master?

Reply to this email directly or view it on GitHub:
#351 (comment)

davidchang · 2013-01-12T20:16:41Z

Volunteer

ghost assigned mhevery May 25, 2011

Codier closed this as completed in e6ee994 Jun 17, 2011

lanterndev mentioned this issue Jan 12, 2013

add ng-open attribute for html5 details elements #1797

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Binding to "disabled" attribute fails on IE7/8 #351

Binding to "disabled" attribute fails on IE7/8 #351

idosela commented May 25, 2011

mhevery commented May 25, 2011

psyho commented May 26, 2011

mhevery commented May 26, 2011

IgorMinar commented Jun 2, 2011

mhevery commented Jun 5, 2011

davidchang commented Jan 12, 2013

Binding to "disabled" attribute fails on IE7/8 #351

Binding to "disabled" attribute fails on IE7/8 #351

Comments

idosela commented May 25, 2011

mhevery commented May 25, 2011

workaround

proposed fix

psyho commented May 26, 2011

mhevery commented May 26, 2011

IgorMinar commented Jun 2, 2011

mhevery commented Jun 5, 2011

davidchang commented Jan 12, 2013