This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(input): don't apply textInput to <input type="file">
textInput shouldn't be applied to file inputs to ease writing of custom file input directives. This change prevents file inputs from instantiating the text input parser/formatter pipelines. Closes #6247 Closes #6231
- Loading branch information
a9fcb0d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apparently this introduces a new bug where attempting to extract a string from a file input returns nothing. is there a workaround for this?
edit: confirmed, removing line 428 ('file': noop) repairs the bug. isn't it more important to be able to validate file type, file presence etc.? this broke my custom directive https://gist.github.com/djvs/c407d422c1fb63498601 as well as some string-based validations