fix(events): fixing IE specific issues

IE doesn't have Array#indexOf and [].splice.call doesn't work there either.
angular · Aug 25, 2011 · 452607f · 452607f
1 parent 1940128
commit 452607f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/Scope.js b/src/Scope.js
@@ -569,10 +569,11 @@ Scope.prototype = {
    * @param {function} listener Function to remove.
    */
   $removeListener: function(name, listener) {
-    var namedListeners = this.$$listeners[name];
-    var i;
+    var namedListeners = this.$$listeners[name],
+        i;
+
     if (namedListeners) {
-      i = namedListeners.indexOf(listener);
+      i = indexOf(namedListeners, listener);
       namedListeners.splice(i, 1);
     }
   },

diff --git a/test/ScopeSpec.js b/test/ScopeSpec.js
@@ -596,7 +596,7 @@ describe('Scope', function() {
           scope.$broadcast('fooEvent', 'do', 're', 'me', 'fa');
 
           expect(args.length).toBe(5);
-          expect([].splice.call(args, 1)).toEqual(['do', 're', 'me', 'fa']);
+          expect(sliceArgs(args, 1)).toEqual(['do', 're', 'me', 'fa']);
         });
       });
     });