Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Reuse ui.bootstrap.typeahead functionality #1

Closed
dimirc opened this issue Nov 6, 2013 · 7 comments
Closed

Reuse ui.bootstrap.typeahead functionality #1

dimirc opened this issue Nov 6, 2013 · 7 comments

Comments

@dimirc
Copy link
Contributor

dimirc commented Nov 6, 2013

typeahead.js already is an AngularJS native directive, so maybe we could reuse all that functionality and extend it.

typeahead module (ui.bootstrap.typeahead) depends on:

  • 2 modules more ['ui.bootstrap.position', 'ui.bootstrap.bindHtml']
  • 2 templates (typeahead-match.html and typeahead-popup.html)
  • css from Bootstrap
@pkozlowski-opensource
Copy link
Member

@dimirc @ProLoser I saw your previous discussion so jumping here. What I'm planning to do in the near (well, 3-6 weeks) future is to extract typeahead's functionality into a separate controller to make it extensible. So if we need to sync on refactorings just ping me.

Not sure how close those 2 directives are and how much code we can reuse, though.

@dimirc
Copy link
Contributor Author

dimirc commented Nov 6, 2013

There are some interesting comments on this topic at angular-ui/bootstrap#454

@dimirc
Copy link
Contributor Author

dimirc commented Nov 6, 2013

@pkozlowski-opensource you mean a new repository with just typeahead (without additional dependencies) or what's the idea?

@pkozlowski-opensource
Copy link
Member

No, I was refferring to internal refactoring of an existing directive.

@ProLoser
Copy link
Member

ProLoser commented Nov 6, 2013

@pkozlowski-opensource have you thought about the fact that BS3 drops typeahead and relocates it to a separate project. I was wondering if you gave it thought at all about doing the same. My guess as to why they did it was because they were starting to realize the plugin itself is a project in of itself (compared to almost all the other plugins).

@ProLoser
Copy link
Member

ProLoser commented Nov 6, 2013

Although I suppose since you guys have datepickers and timepickers as part of the 'core' then there isn't a big point to arbitrarily leave out typeahead.

@ProLoser
Copy link
Member

ProLoser commented Nov 7, 2013

@dimirc FYI I actually didn't start off with their lib because I wanted to start from scratch and see if we could simplify their implementation further and still provide better feature support. I've been working on this sort of lib for the entire lifespan of AngularUI.

See #3

If we build this tool to be extensible enough, then you should be able to have the output be the equivalent to Bootstrap HTML and as such it should be ready-to-go. We (or ui-bootstrap) can even provide optional templates or a default configuration of this plugin. However, I want to aim for wider support than strictly bootstrap.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants