This repository has been archived by the owner on Sep 8, 2020. It is now read-only.
Don't wrap callback functions which need to return value to fullcalendar... #123
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to http://arshaw.com/fullcalendar/docs1/mouse/eventClick/ and http://arshaw.com/fullcalendar/docs1/event_data/eventDataTransform/ , after fullcalendar calls
eventClick
andeventDataTransform
, it will then consume the return value.If we wrap those two callbacks with
wrapFunctionWithScopeApply
, the wrapper function calls the wrapped function with$timeout
and never pass the return value back to fullcalendar.This breaks the design of these callbacks.
To fix this issue, the patch just avoid to wrap
eventClick
andeventDataTransform
. I just did a quick scan of the documents and only find these two. There might be more callbacks to ignore.This PR fixed #122