Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

workaround for nested transclude scope #2134

Closed
wants to merge 2 commits into from
Closed

workaround for nested transclude scope #2134

wants to merge 2 commits into from

Conversation

paulpflug
Copy link

see #2110 for details

also added proper cleanup

@paulpflug
Copy link
Author

yes - you are right: jqLite children() doesn't support selectors.
How to find the ng-transclude element properly?
If we don't search it, the content gets inserted twice.
How static is the template?

@pkozlowski-opensource
Copy link
Member

@paulpflug so, this is the crux of the issue - as soon as we try to go with the "manual trasclusion" we need to find an element that the content should be transcluded into... And this is pain in the #)$(&)$* as without jQuery it is not easy to do... And even with jQuery it is not bullet-proof since people could use, in their custom template something like data-ng-transclude... The main problem is that people can provide their own templates and we've got little control over what they are going to use....

I'm afraid that I don't know what is the best solution here.... This is why I was saying that all the alternatives I can think of are worse that the current situation...

pkozlowski-opensource added a commit that referenced this pull request May 4, 2014
@pkozlowski-opensource
fix(modal): add a work-around for transclusion scope
56f1b0a 
Fixes #2110
Closes #2134
@pkozlowski-opensource pkozlowski-opensource mentioned this pull request May 4, 2014
Closed
@pkozlowski-opensource
Copy link
Member

@paulpflug @chrisirhc could you guys please have a look at my attempt for fixing it at #2143 ?

@paulpflug paulpflug closed this May 4, 2014
pkozlowski-opensource added a commit that referenced this pull request May 5, 2014
@pkozlowski-opensource
fix(modal): add a work-around for transclusion scope
0b31e86 
Fixes #2110
Closes #2134
Closes #2143
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulpflug @pkozlowski-opensource