Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization for other languages? #7

Closed
matteobucci opened this issue Apr 4, 2020 · 14 comments
Closed

Localization for other languages? #7

matteobucci opened this issue Apr 4, 2020 · 14 comments
Assignees
Labels
enhancement New feature or request PR Welcome

Comments

@matteobucci
Copy link

I've just found this project and I found it amazing!
However I'm wondering: is there any support for localization in other languages? Is this something achievable manually or planned?

@AnthonyNahas AnthonyNahas self-assigned this Apr 7, 2020
@AnthonyNahas AnthonyNahas added the enhancement New feature or request label Apr 7, 2020
@AnthonyNahas
Copy link
Member

I will take this feature into consideration for the next release

@matteobucci
Copy link
Author

Thank you very much Anthony. I know that I shouldn't ask but, since this is a library I'm willing to use in one of my projects, have you any idea about when it will be implemented?
Furthermore, is there anything that I can do to help you in implementing this feature? I would be very happy to give my contribution.

@AnthonyNahas
Copy link
Member

@matteobucci I have like over 20 open source projects that I maintain + 2 own productive apps ...
that's why this could be implemented in the next few weeks (maybe earlier)

The idea behind i18n for this library:

  1. First option: via @Input() -->
  2. or via angular v9 i18n

the db should be translated too..

@EduardoSimon
Copy link

Hi, any way this could be integrated with https://github.com/ngx-translate/core?

@fuegonju
Copy link

fuegonju commented Jul 7, 2020

I'm looking forward to be able to use other languages too

@AnthonyNahas
Copy link
Member

Supporting i18n could be a challenge

@ACMCMC
Copy link
Contributor

ACMCMC commented Sep 7, 2020

Are translations for new languages welcome?

@AnthonyNahas
Copy link
Member

@ACMCMC yes why not

@Benny739
Copy link

Benny739 commented Oct 2, 2020

Any plans when you will release the changes with the language support?

@AnthonyNahas
Copy link
Member

@Benny739 I have more than 15 open source projects to maintain... so please be patient 🍻

@rodent129
Copy link

Can help to add Chinese translation? Thanks a lot.

@AnthonyNahas
Copy link
Member

yes you can do it via an appropriate PR

@Rogermax
Copy link
Contributor

I made a PR (#80) solving this. This issue is the same as #67.

I hope it works.

@jdayssol
Copy link

jdayssol commented Sep 2, 2021

@Rogermax , thanks for this PR! I hope this will be merged soon, I will need this feature for my project :)

AnthonyNahas added a commit that referenced this issue Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR Welcome
Projects
None yet
Development

No branches or pull requests

9 participants