Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console.log() still present in the last version #49

Closed
christophe-mailfert opened this issue Oct 27, 2020 · 2 comments
Closed

console.log() still present in the last version #49

christophe-mailfert opened this issue Oct 27, 2020 · 2 comments
Assignees
@AnthonyNahas
Labels
ready

Comments

@christophe-mailfert
Copy link

Describe the bug
Some console.log is writen by the module.

lang en
angular-material-extensions-select-country.js:205 running with default
angular-material-extensions-select-country.js:129 writeValue

To Reproduce
Steps to reproduce the behavior:

  1. Load module
    2 Display field in reactiv form
  2. Open console

Expected behavior
I think debug log should never appear.

Desktop (please complete the following information):

  • Version 3.0.2
@AnthonyNahas AnthonyNahas self-assigned this Oct 27, 2020
@AnthonyNahas
Copy link
Member

I will move them out in the next release

thank you

AnthonyNahas added a commit that referenced this issue Nov 3, 2020
@AnthonyNahas
fix(lib): removed logs #49
edc19ab
@AnthonyNahas
Copy link
Member

this has been fixed in v3.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnthonyNahas AnthonyNahas

Labels
ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christophe-mailfert @AnthonyNahas