Unable to check existence using glob

[Fleuv]

Unable to check for files existence using the glob character (*).

Steps to reproduce

Use the following job in your github workflow.

...

jobs:
  my_job_id:
    runs-on: ubuntu-latest
    steps:
      - name: Add foo package
        run: mkdir -p package/foo/ && touch package/foo/package.json
      - name: Add bar package
        run: mkdir -p package/bar/ && touch package/bar/package.json
      - name: Check if files exist
        uses: andstor/file-existence-action@v1
        id: check_files
        with:
          files: "packages/*/package.json"
      - name: Result
        if: steps.check_files.outputs.files_exists == 'true'
        run: echo "Files exist"

Expected output:

Files exist

Actual output:

These files doesn't exist: packages/*/package.json

[elizabrock]

This action uses fs.access, which checks for the literal existence of the string that is passed in.

If you want to add glob functionality, I think it would be relatively easy to modify the code to use the glob package instead.

[andstor]

Hi 👋

Yes, @elizabrock you are correct. This action does not currently support globs.

However, adding support for globs is something I think would be really useful. The glob package seems to be a great solution.

Is this something you would be interested in implementing @elizabrock ?

[nterbogt]

I would like to see this functionality also.

[joergi]

@andstor - maybe add the #Hacktoberfest label to get it done?
https://hacktoberfest.digitalocean.com/

[andstor]

@andstor - maybe add the #Hacktoberfest label to get it done?

Added 👌

[AraHaan]

instead of using fs and glob why not use the glob-fs package?

[Simonl9l]

Any word on an enhancement here?

[andstor]

Hi 👋

Version v1.1.0 now supports glob patterns 🥳
Feedback is much appreciated 🙏