bootstrap-vz fails to unmount /dev if interrupted

[nbraud]

I interrupted a bootstrap-vz run just after it bind-mounted /dev into the VM's rootfs, and it failed to clean it up: see log 20160224161357_jessie-vagrant.log.

[andsens]

I think you actually managed to interrupt it during the mounting process, meaning bootstrap-vz hasn't had the chance to flag the mount as completed, which in turn causes it to not unmount it during rollback.
I'm closing this in favor of #292.

[nbraud]

@andsens My point was that this incident exposed a race condition, regardless of #293.

[nbraud]

@andsens I guess you don't think this is worth re-opening?

[andsens]

Oh! I see what you mean now (reopening).
Hm, so the problem is we manage the state of a mount separately from what is actually happening on the system, which can be fixed. Either that, or we register a mount as successful before actually mounting it, and then simply make the unmounting operation resistant against unmounts failing specifically because something isn't mounted.

I like the solution of fixing the synchronization between bootstrap-vz's state and the system a lot more.

Any other ideas?

[nbraud]

Well, it's not a part of bootstrap-vz I'm familiar with, at all.