Use kotlin build.gradle in ComposeStarter #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
reviewed
Jul 9, 2024
| implementation(libs.androidx.splashscreen) | ||
|
|
||
| // Compose for Wear OS Dependencies | ||
| // NOTE: DO NOT INCLUDE a dependency on androidx.compose.material:material. |
There was a problem hiding this comment.
If we really believe this we should probably change this to a Lint?
Or fail the build if present. I can try the latter if you agree.
For follow up.
There was a problem hiding this comment.
Thanks that would be great!
yschimke
reviewed
Jul 9, 2024
| implementation(libs.horologist.compose.material) | ||
|
|
||
| // Preview Tooling | ||
| implementation(libs.compose.ui.tooling.preview) |
There was a problem hiding this comment.
For follow up - these are confusing because name is truncated and missing "wear".
androidx-compose-ui-tooling = { module = "androidx.wear.compose:compose-ui-tooling", version.ref = "compose-ui-tooling" }
There was a problem hiding this comment.
Happy to address in another PR and apply to all samples, what about something like androidx-wear-compose-ui-tooling?
yschimke
approved these changes
Jul 9, 2024
|
Thanks @yschimke for the review! I just added also https://github.com/android/wear-os-samples/pull/1146/files#diff-97720b8076bde3b9c20d2082ff624094b85cf52190de2198cde1d981198e75b4R16, can you PTAL? |
yschimke
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate guild files from Groovy to Kotlin in ComposeStarter.
Partially fixes #1134