Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jetcaster] Remove HomeState and reduces lambdas into HomeAction #1500

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

mlykotom
Copy link
Contributor

@mlykotom mlykotom commented Nov 8, 2024

[Merge after #1499]

  • it served only as a wrapper for parameters without any additional logic
  • it was unstable and creating new instance each composition, therefore no skipping
  • Reduces amount of passing and potentially making mistake

@mlykotom mlykotom requested a review from a team as a code owner November 8, 2024 16:30
Base automatically changed from mlykotom/jetcaster/fix-progress to main November 18, 2024 09:09
- it served only as a wrapper for parameters without any additional logic
- it was unstable and creating new instance each composition, therefore no skipping

# Conflicts:
#	Jetcaster/mobile/src/main/java/com/example/jetcaster/ui/home/Home.kt
Reduces amount of passing and potentially making mistake
@mlykotom mlykotom force-pushed the mlykotom/jetcaster/simplify-home branch from f6ec85a to ec5e931 Compare November 18, 2024 09:14
@mlykotom mlykotom merged commit 60708b1 into main Nov 21, 2024
2 checks passed
@mlykotom mlykotom deleted the mlykotom/jetcaster/simplify-home branch November 21, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants