Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetcaster UI updates #1489

Closed
wants to merge 9 commits into from
Closed

Jetcaster UI updates #1489

wants to merge 9 commits into from

Conversation

simona-anomis
Copy link
Contributor

@simona-anomis simona-anomis commented Oct 9, 2024

Add to Jetcaster: shared elements, swipetodismiss, lazy list animations and removal of episode from queue

jetcasterdemo.mp4

@simona-anomis simona-anomis requested a review from riggaroo October 9, 2024 13:18
@simona-anomis simona-anomis self-assigned this Oct 9, 2024
@simona-anomis simona-anomis requested a review from a team as a code owner October 9, 2024 13:18
Copy link
Collaborator

@riggaroo riggaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, would you be able to add some screen recordings when you have them?

Copy link
Collaborator

@riggaroo riggaroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! :)

# Conflicts:
#	Jetcaster/mobile/src/main/java/com/example/jetcaster/ui/home/Home.kt
@yongsuk44
Copy link
Contributor

With PR #1486 merged into the main branch, I have worked on updating the logic in this PR to use only Grid. Would it be alright to contribute these changes to the current branch?

  • I have modified it so that the AnimationScope is not applied when the device is unfolded and the detail screen is open.
  • I fixed an issue where SharedElementTransition was not applied in the library list.

If you are working on this separately, feel free to skip this comment.

fold.mp4

@simona-anomis
Copy link
Contributor Author

With PR #1486 merged into the main branch, I have worked on updating the logic in this PR to use only Grid. Would it be alright to contribute these changes to the current branch?

  • I have modified it so that the AnimationScope is not applied when the device is unfolded and the detail screen is open.
  • I fixed an issue where SharedElementTransition was not applied in the library list.

If you are working on this separately, feel free to skip this comment.

fold.mp4

Hiya @yongsuk44 - thanks for your contributions! Just to clarify - have you already made these changes locally, but just haven't committed to this PR? If so, please let me know, as I was planning to do this today :) just so we don't duplicate the work. If you've already done the work, please feel free to commit to this branch. Thanks again!

@yongsuk44
Copy link
Contributor

@simona-anomis
I've created a separate PR #1492 to merge into the 'jetcaster-ui-update' branch.
Could you please take a look? 🙂

@simona-anomis simona-anomis deleted the anomis/jetcaster-ui-update branch November 6, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants