-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetcaster UI updates #1489
Jetcaster UI updates #1489
Conversation
…ns and removal of episode from queue
Jetcaster/mobile/src/main/java/com/example/jetcaster/ui/home/category/PodcastCategory.kt
Outdated
Show resolved
Hide resolved
Jetcaster/core/domain/src/main/java/com/example/jetcaster/core/model/EpisodeInfo.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, would you be able to add some screen recordings when you have them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! :)
# Conflicts: # Jetcaster/mobile/src/main/java/com/example/jetcaster/ui/home/Home.kt
With PR #1486 merged into the main branch, I have worked on updating the logic in this PR to use only Grid. Would it be alright to contribute these changes to the current branch?
If you are working on this separately, feel free to skip this comment. fold.mp4 |
Hiya @yongsuk44 - thanks for your contributions! Just to clarify - have you already made these changes locally, but just haven't committed to this PR? If so, please let me know, as I was planning to do this today :) just so we don't duplicate the work. If you've already done the work, please feel free to commit to this branch. Thanks again! |
@simona-anomis |
Add to Jetcaster: shared elements, swipetodismiss, lazy list animations and removal of episode from queue
jetcasterdemo.mp4