[Jetcaster] UI polish of TV module and resolved navigation & focus traversal issue in player screen #1481
Conversation
# Conflicts: # Jetcaster/gradle/libs.versions.toml
pflammertsma
requested review from
dturner and
chikoski
and removed request for
dturner
| @@ -72,8 +72,18 @@ private fun EpisodeThumbnail( | |||
| Card( | |||
| onClick = onClick, | |||
| interactionSource = interactionSource, | |||
| scale = CardScale.None, | |||
| scale = CardDefaults.scale(scale = 0.85f, focusedScale = 1.0f), | |||
There was a problem hiding this comment.
Scaling is intentionally disabled. We should keep the original intention.
There was a problem hiding this comment.
I don't feel the previous behavior accurately reflects our design best practices to clearly indicate focus, because the card is very large and it's easy to overlook the outline. The added padding has compensated for the scaling elsewhere.
| @@ -40,8 +41,18 @@ internal fun PodcastCard( | |||
| Card( | |||
| onClick = onClick, | |||
| interactionSource = it, | |||
| scale = CardScale.None, | |||
| shape = CardDefaults.shape(RoundedCornerShape(12.dp)) | |||
| scale = CardDefaults.scale(scale = 0.9f, focusedScale = 1.0f), | |||
There was a problem hiding this comment.
Scaling is intentionally disabled. Would you keep the original code?
There was a problem hiding this comment.
Same thoughts as the comment in EpisodeCard.
Jetcaster/tv/src/main/java/com/example/jetcaster/tv/ui/component/EpisodeCard.kt
Outdated
Show resolved
Hide resolved
Jetcaster/tv/src/main/java/com/example/jetcaster/tv/ui/component/PodcastCard.kt
Outdated
Show resolved
Hide resolved
Jetcaster/tv/src/main/java/com/example/jetcaster/tv/ui/player/PlayerScreen.kt
Outdated
Show resolved
Hide resolved
Jetcaster/tv/src/main/java/com/example/jetcaster/tv/ui/player/PlayerScreen.kt
Outdated
Show resolved
Hide resolved
|
This issue has been automatically marked as stale because it has not had any recent activity. Please comment here if it is still valid so that we can reprioritize it. Thank you for your contributions. |
# Conflicts: # Jetcaster/gradle/libs.versions.toml # Jetcaster/mobile/src/main/java/com/example/jetcaster/ui/home/Home.kt # Jetcaster/mobile/src/main/java/com/example/jetcaster/ui/home/HomeViewModel.kt
No description provided.