Refactor FAB with onScroll animation #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentrengrove
requested changes
Oct 1, 2024
| ) | ||
| } | ||
| contentColor = MaterialTheme.colorScheme.onTertiaryContainer, | ||
| expanded = emailLazyListState.isScrollingUp() |
There was a problem hiding this comment.
No need for an extension here, you can replace this with
Suggested change
| expanded = emailLazyListState.isScrollingUp() | |
| expanded = emailLazyListState.lastScrolledBackward || | |
| !emailLazyListState.canScrollBackward |
There was a problem hiding this comment.
Thank you! I really appreciate it. It's been exciting to try Android development again after 4 years! I've updated as per suggestion.
|
Looks like it just needs formatting. You should be able to just run
|
I've applied spotless to format the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The large FAB looks weird with the design. So I've refactored it to use Extended FAB and added animation onScroll like Gmail does.
New:
Old:
We can also consider showing/hiding the Search Bar & Bottom Navigation Bar on the scroll. I will try to do it next if this PR gets merged.
Thank you.