Bump dependencies #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move chalk from devDependencies to dependencies - drop support for node 12 - fix import/extensions issues - fix unicorn/prevent-abbreviations issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chalk is used as a dependency, but was declared as a devDependency. This was causing issues when using yarn's plug'n'play node linker as lighthouse-ci was attempting to import a package it had not declared.
Node 12 was removed as a supported version as support for it was dropped in lighthouse 9. I thought that this would normally be a major version update, but I saw that lighthouse-ci dropped support for node 10 in a minor version too (1.13.0).
chalk, meow, ora, and xo have not been upgraded to more recent versions in the scope of this PR as they are now all ESM only.