-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: to_html implemented #631
Open
icannotnamemyself
wants to merge
14
commits into
amueller:main
Choose a base branch
from
icannotnamemyself:feature-to-html
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature: to_html implemented #631
icannotnamemyself
wants to merge
14
commits into
amueller:main
from
icannotnamemyself:feature-to-html
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why can't I pass those checks ........ 😭 |
hey! Thanks for the PR. I thought I had remove the method, as I figured the SVG export would be enough. |
Also, I think, CI is just broken right now and it's not your fault :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: to_html finished
luckily , although they are two different type of graph , canvas is transformed just the same as svg.so thanks to @jojolebarjos , I can finish part of "to_canvas" quickly with reference to his to_svg method.
Here are some differences I've found bettween canvas and svg:
Fix: text overlap
when I tested the to_svg method, I found there are some text overllaped together , but after I add a font family attribute , the problem is gone
some problems