setup: use scikit-build for building C module #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scikit-build is a drop-in replacement to setuptools.setup function allowing to easily compile and package extensions (C/C++/Cython) by bridging CMake and setuptools. See http://scikit-build.org CMake is an open-source, cross-platform family of tools designed to build, test and package software. See https://cmake.org Ninja is a small build system with a focus on speed. It differs from other build systems in two major respects: it is designed to have its input files generated by a higher-level build system, and it is designed to run builds as fast as possible. See https://ninja-build.org/ By adding the "pyproject.toml" file, we ensure the required packages are installed when running "pip wheel . -w dist". To streamline testing and creation of source or built distribution, the "requirements-dev.txt" was also updated to include scikit-build, cmake and ninja. This commit introduces new build dependencies all available as wheels: scikit-built, cmake and ninja.
|
I feel like using CMake for this is a bit overkill. Like the configuration and dependencies got significantly longer. Also it requires new contributors to understand more things. |
This streamlines the maintenance of the wordcloud package ensuring an always up-to-date c module is generated. When Python 3.8 will be release, adding an entry in each CI configuration file will be sufficient.
|
I anticipate, It will streamline the process:
There was a lot of message in the issue tracker about which compiler, etc ... this could help. Installing, these wheels is fast and their available for all python version. |
|
Also, if this causes more problem that is is claiming to solve, I will help revert it. As you noticed, I have a good understanding of the word_cloud code base and can definitely help, |
|
Alright, feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scikit-build is a drop-in replacement to setuptools.setup function
allowing to easily compile and package extensions (C/C++/Cython) by
bridging CMake and setuptools. See http://scikit-build.org
CMake is an open-source, cross-platform family of tools designed
to build, test and package software. See https://cmake.org
Ninja is a small build system with a focus on speed. It differs from other
build systems in two major respects: it is designed to have its input
files generated by a higher-level build system, and it is designed
to run builds as fast as possible. See https://ninja-build.org/
By adding the "pyproject.toml" file, we ensure the required packages
are installed when running "pip wheel . -w dist".
To streamline testing and creation of source or built distribution, the
"requirements-dev.txt" was also updated to include scikit-build, cmake
and ninja.
This commit introduces new build dependencies all available as wheels:
scikit-built, cmake and ninja.