Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail streams only with StreamException #354

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Conversation

trowski
Copy link
Member

@trowski trowski commented Dec 8, 2023

This wraps exceptions used to fail response body so that ReadableStream::read() only throws instances of StreamException, fulfilling the interface contract.

@trowski trowski requested a review from kelunik December 8, 2023 00:52
@trowski trowski merged commit fffc8c3 into 5.x Dec 10, 2023
0 of 8 checks passed
@trowski trowski deleted the wrap-stream-exceptions branch April 21, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant