Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump watch version to ~0.18.0 #101

Merged
merged 2 commits into from
Aug 17, 2017
Merged

Bump watch version to ~0.18.0 #101

merged 2 commits into from
Aug 17, 2017

Conversation

okuryu
Copy link
Contributor

@okuryu okuryu commented Aug 16, 2017

https://www.sourceclear.com/registry/libraries/watch/javascript/npm/lid-7332/versions/0.10.0/vulnerabilities

Licenses
UNKNOWN

The sane currently depends on watch@~0.10.0. The watch@~0.10.0 doesn't have correct a license information by SourceClear. The correct license information have added in watch v0.17.0 or later.
mikeal/watch@7802a55

I tried to upgrade watch version to the latest version v1.0.2, but watch v0.19.3 or later seems to have a breaking change.
https://www.npmjs.com/package/watch
mikeal/watch@5ac4690

I think this patch resolves this issue with maintenance of back compatible for sane. And, the test code changes also are auto fixing by npm test and prettier.

@amasad amasad merged commit 488b969 into amasad:master Aug 17, 2017
@amasad
Copy link
Owner

amasad commented Aug 17, 2017

thanks

@okuryu okuryu deleted the bump-watch branch August 17, 2017 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants