Support sites deployed on a path other than "/" when generating header and footer links #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddgrant
force-pushed
the
fix-header-and-footer-links-when-generating-relative-links
branch
2 times, most recently
from
38c3bf1 to
22d9a8b
Compare
lfdebrux
reviewed
Jun 6, 2023
lfdebrux
reviewed
Jun 6, 2023
lfdebrux
reviewed
Jun 6, 2023
|
A couple of small comments, otherwise looks good to me. Thanks for submitting this PR, sorry it's taken a while to be reviewed. |
…ing header and footer links.
eddgrant
force-pushed
the
fix-header-and-footer-links-when-generating-relative-links
branch
from
22d9a8b to
7e16828
Compare
lfdebrux
approved these changes
Jun 7, 2023
lfdebrux
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks 👋
What’s changed
v3.2.0 contained changes to support support sites which were configured to generated relative links. At the time I implemented these changes we were not making use of the
header_linksandfooter_linkslinks functionality. We have since started using both which caused me to realise that the relative link generation did not work for either.This PR extends the relative link generation functionality such that it works for both header and footer links. I have also updated the tests to be more comprehensive so that they test link generation for both internal and external links, as I found that external links were not being correctly identified in all cases previously.
Hope this all makes sense. Would be great if someone could give it some 👀 and consider it for inclusion. Very happy to discuss and fettle if required.
Cheers!