Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE 221 - Tabbing on search results in mobile #224

Merged
merged 1 commit into from
Mar 25, 2021
Merged

ISSUE 221 - Tabbing on search results in mobile #224

merged 1 commit into from
Mar 25, 2021

Conversation

iqbalgds
Copy link
Contributor

@iqbalgds iqbalgds commented Mar 24, 2021 •
edited
Loading

  • In mobile view, when you tab through the search results and tab past
    the last result:
    • The focus appears lost as it goes to a 'close table of contents' button that
      is not in view.
  • Update the SASS to hide the button when the search results are open.

⚠️ Don't forget to update the gem version in the CHANGELOG before merging! When you're ready to release bump version file and generate a tag. ⚠️

@iqbalgds iqbalgds force-pushed the issue-221-tabbing-when-on-search-results-in-mobile branch from 1cb53cf to 33c40e5 Compare March 24, 2021 17:49
@iqbalgds iqbalgds mentioned this pull request Mar 24, 2021
Closed
richardTowers
richardTowers approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@richardTowers richardTowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

As with the other PR, the changelog heading should probably be "Unreleased", so you can bundle this up with any other changes you want to release.

@iqbalgds
ISSUE 221 - Tabbing on search results in mobile
b9f011c 
- In mobile view, when you tab through the search results and tab past
  the last result:
  - The focus appears lost as it  goes to a 'close table of contents' button that
    is not in view.
- Update the SASS to hide the button when the search results are open.
@iqbalgds iqbalgds force-pushed the issue-221-tabbing-when-on-search-results-in-mobile branch from 33c40e5 to b9f011c Compare March 25, 2021 12:03
@iqbalgds iqbalgds merged commit bd3fad5 into master Mar 25, 2021
@iqbalgds iqbalgds deleted the issue-221-tabbing-when-on-search-results-in-mobile branch March 25, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardTowers richardTowers richardTowers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iqbalgds @richardTowers