Remove unnecessary explicit dependencies: sprockets, activesupport, sass and pry #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevindew
force-pushed
the
unnecessary-deps
branch
2 times, most recently
from
b167e42 to
55d8d31
Compare
richardTowers
approved these changes
Mar 15, 2021
|
Do you want to bump the version to |
I'm optimistically hoping I might get my long protracted bug fix PR into this release too. But if that hits a snag I'll release them separately. |
This is implicitly required by middleman-sprockets and is not referenced explicitly in the code. This dependency is unnecessarily set to a minimum version of 4.0.0 which causes problems for some consumers (notably govuk-developer-docs) that haven't made the (rather painful) migration to sprockets 4.
This is a deprecated library where there are no explicit references to it in the code.
This was presumably installed just to allow debugging within this gem and is not a dependency that clients of this need.
I can't find any places where this is used in this project.
Since Ruby 2.7 has bundler installed and is the minimum version for this gem there isn't need to flag bundler as a development dependency.
This also fixes the formatting of the changelog from 125
kevindew
force-pushed
the
unnecessary-deps
branch
from
55d8d31 to
e86d2f9
Compare
richardTowers
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the exception of pry, none of these dependencies are explicitly referenced in the code (activesupport and sprockets are implicit though). This removes an unnecessary constraint on sprockets 4, as middleman-sprockets depends on 3 and up which causes problems for apps that integrate with govuk_publishing_components.