-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jQuery from v1.12.4 to v3.5.1 #203
Conversation
Thanks for raising the draft PR @chao-xian! I've made an attempt at updating third-party JavaScript files. jQuery and Lodash are now up-to-date. Other points to note:
|
Re-opening this so we can rebase, review and merge it |
jQuery v3.5.1. available from: https://code.jquery.com/jquery-3.5.1.min.js
Custom build using lodash-cli (see line 4).
8ab7225
to
c6d0bbd
Compare
Thanks for the contribution @ESKYoung , @chao-xian. I especially appreciate the detailed comment explaining the work done. Sorry it took so long for us to get around to reviewing it, the tech-docs-gem has been languishing for a bit, but we have a new working group now! 🎉 Hopefully I should be able to get this merged ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me; I've reviewed the changes in lodash.js, confirmed that jquery.js matches what is on code.jquery.com, and checked that the search still works when using the gem in the GOV.UK Frontend tech docs.
I think this just needs an approval from @m-green, and it can then be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve from my side - thank you everyone!
Thanks everyone! |
Main one is govuk-tech-docs gem v2.4.3 which brings - [#236: Fix search 'autocomplete' behaviour](alphagov/tech-docs-gem#236) - [#203: Update vendored javascripts](alphagov/tech-docs-gem#203)
jQuery v3.5.1. available from:
https://code.jquery.com/jquery-3.5.1.min.js