Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jQuery from v1.12.4 to v3.5.1 #203

Merged
merged 2 commits into from
Aug 27, 2021
Merged

Conversation

chao-xian
Copy link
Contributor

jQuery v3.5.1. available from:
https://code.jquery.com/jquery-3.5.1.min.js

@ESKYoung
Copy link
Contributor

ESKYoung commented Feb 4, 2021

Thanks for raising the draft PR @chao-xian! I've made an attempt at updating third-party JavaScript files. jQuery and Lodash are now up-to-date. Other points to note:

  1. (lib/assets/javascripts/_vendor/modernizr.js) The existing Modernizr v3.3.1 file appears to be a custom build (see line 2). However, the link in line 2 to the Modernizr site should not be used, as the site is out-of-date and broken
    • I tried rebuilding v3.3.1 using the same build parameters, but there appeared to be differences with our file
    • The latest version is v3.11.4, but I'm not sure how to make the custom build or if I should given the above
  2. (spec/javascripts/helpers/lunr.min.js) I tried updating Lunr to v2.3.9, but the tests failed, and the built application.js file still had v0.7.0 in it, so I rolled back those changes
  3. (lib/assets/javascripts/_vendor/jquery.mark.js) mark.js seems to be latest release, but the repo seems to be stale (last master commit in Aug 2019)
  4. (lib/assets/javascripts/_vendor/fixedsticky.js) Latest release of fixedsticky.js, but this repo has been deprecated.

@lfdebrux
Copy link
Member

lfdebrux commented Aug 27, 2021

Re-opening this so we can rebase, review and merge it

@lfdebrux lfdebrux reopened this Aug 27, 2021
Eric Young added 2 commits August 27, 2021 13:45
Custom build using lodash-cli (see line 4).
@lfdebrux lfdebrux force-pushed the update-vendor-javascripts branch from 8ab7225 to c6d0bbd Compare August 27, 2021 12:45
@lfdebrux lfdebrux marked this pull request as ready for review August 27, 2021 12:46
@lfdebrux
Copy link
Member

Thanks for the contribution @ESKYoung , @chao-xian. I especially appreciate the detailed comment explaining the work done.

Sorry it took so long for us to get around to reviewing it, the tech-docs-gem has been languishing for a bit, but we have a new working group now! 🎉

Hopefully I should be able to get this merged ASAP.

Copy link
Member

@lfdebrux lfdebrux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me; I've reviewed the changes in lodash.js, confirmed that jquery.js matches what is on code.jquery.com, and checked that the search still works when using the gem in the GOV.UK Frontend tech docs.

I think this just needs an approval from @m-green, and it can then be merged.

@m-green m-green self-requested a review August 27, 2021 13:10
Copy link
Contributor

@m-green m-green left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve from my side - thank you everyone!

@chao-xian chao-xian merged commit 40a8821 into master Aug 27, 2021
@chao-xian chao-xian deleted the update-vendor-javascripts branch August 27, 2021 13:11
@chao-xian
Copy link
Contributor Author

Thanks everyone!

@lfdebrux lfdebrux mentioned this pull request Sep 13, 2021
kr8n3r added a commit to alphagov/paas-tech-docs that referenced this pull request Sep 15, 2021
Main one is govuk-tech-docs gem v2.4.3 which brings

- [#236: Fix search 'autocomplete' behaviour](alphagov/tech-docs-gem#236)
- [#203: Update vendored javascripts](alphagov/tech-docs-gem#203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants