Add show_review_banner configuration option #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've changed the `rebuild_site!` function to take an `overrides` argument which is a hash of options that will be added to the tech-docs config. Now you don't need to copy/paste the entire YAML config just to change a single option!
Previously, disabling the review banner that appears at the bottom of pages required a weird JavaScript hack. I've added a new config option that will allow users to disable the banner globally.
bravegrape
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, disabling the review banner that appears at the bottom of pages
required a weird JavaScript hack. I've added a new config option that will
allow users to disable the banner globally.