-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the Tudor crown in the Header component (v4.x) #4278
Conversation
04b6638
to
568a6d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I ummed and ahhed about the width="32"
targeting over using a modifier class but it's probably the simplest way to do it considering we'd ask users to change that value anyway, and IMO the impact of a user missing setting width to 32 if they're not using our macros is pretty low.
We should be explicit in our release notes that users not using our macro should set the width when updating the svg, or ideally just re-copy a new svg.
89dbc0d
to
8b1a1ca
Compare
8b1a1ca
to
45ec2c4
Compare
Merging in preparation for release w/c 15th January. |
Implement the Tudor crown iconography in the Header component. Part of #4179.
See #4297 for the equivalent changes for Frontend v5.
Warning
This PR should not be merged until we have approval to do so.
Changes
useTudorCrown
, to switch to using the new Tudor crown.Todo