Add inverse button styles #3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port the inverse button styles from the GaaP product page repository into Frontend
owenatgov
reviewed
Apr 26, 2023
owenatgov
approved these changes
Apr 27, 2023
|
Will there be guidance for this component in the design system, or is this a hidden feature for now? |
This was referenced Apr 27, 2023
|
@paulrobertlloyd I don't see why not! We have documentation for the other button alternatives and the inverse link style, I don't see why this would be different. |
peteryates
added a commit
to x-govuk/govuk-form-builder
that referenced
this pull request
May 23, 2023
Inverse buttons were added to govuk-frontend in PR #3556[0] [0] alphagov/govuk-frontend#3556
peteryates
added a commit
to x-govuk/govuk-components
that referenced
this pull request
May 28, 2023
Inverse buttons were added to govuk-frontend in PR #3556 alphagov/govuk-frontend#3556
2 tasks
This was referenced Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the inverse button styles from the GaaP product page repository into Frontend.
I haven't added any additional automated or accessibility tests (not that other stylistic variants have them), but these styles have existed in the wild for a long time already—one would hope that any major issues with the styles had already been identified.
Closes #2267.