Update guidance on assets #4866
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauraghiorghisor-tw
force-pushed
the
add-mention-of-replacements-on-deletion-section
branch
from
5fa5f80 to
76b72a9
Compare
lauraghiorghisor-tw
force-pushed
the
add-mention-of-replacements-on-deletion-section
branch
3 times, most recently
from
b75878a to
849d0d6
Compare
lauraghiorghisor-tw
changed the title
minhngocd
reviewed
Dec 11, 2024
ryanb-gds
reviewed
Dec 11, 2024
There was a problem hiding this comment.
I don't know if the developer docs are quite the right place for some of this stuff - would probably be good to move the heavier stuff into the Asset Manager or Whitehall docs and then link to them from here. I feel the developer manuals are more aimed at "I want to quickly fix a problem without having to understand the whole of asset publishing, what do I do?"
|
On the back of comments:
|
This is a temporary section. We are addressing the root cause of the bugs. A data patch has also been run. Nonetheless, outliers might exist, that we will tackle on 3rd line. This guidance can thus come in handy. I thought about putting this in whitehall, but I feel like it best belongs here, albeit at the bottom of the file.
lauraghiorghisor-tw
force-pushed
the
add-mention-of-replacements-on-deletion-section
branch
from
849d0d6 to
b2954dd
Compare
lauraghiorghisor-tw
force-pushed
the
add-mention-of-replacements-on-deletion-section
branch
from
b2954dd to
e9372bc
Compare
Improve guidance, suggesting a less destructive fix for a broken asset. Linking out to other sources and the whitehall bugs section below. Update the removal in the originating publishing app guidance, as we no longer advise developers to use the `delete_attachment` rake task. We expect them to only delete assets in asset manager, unless they really want to amend anything in the publishing app.
lauraghiorghisor-tw
force-pushed
the
add-mention-of-replacements-on-deletion-section
branch
from
e9372bc to
08a4094
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello