Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDS branding #920

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GDS branding #920

wants to merge 1 commit into from

Conversation

galund
Copy link
Contributor

@galund galund commented Jul 2, 2024

Branding - add logo and change font

  • to make more clear that this is by and for GDS

References:

GDS brand guidelines: https://drive.google.com/file/d/1UU0i_cudRpDdf_qRfgCIRB9YYrFkdGVI/view

@galund galund marked this pull request as ready for review July 2, 2024 12:34
@DaveLee-GDS
Copy link

Looks nice and clean to me.

@cjfryer
Copy link
Member

cjfryer commented Jul 2, 2024

Not using New Transport seems like a very strict interpretation of the Service Manual. While it says your site "must look like GOV.UK if it’s on one of <a list of domains>" I'm not certain it follows that the complement must not.

@galund
Copy link
Contributor Author

galund commented Jul 2, 2024

@cjfryer the quote from the page I linked is:

While you can use the patterns, your site or service must not:
...

  • use the GDS Transport typeface

:-)

@cjfryer
Copy link
Member

cjfryer commented Jul 2, 2024

@galund yes, and that section talks (vaguely) about services that aren't "considered part of GOV.UK."

An equally strict interpretation of the rules would prevent GOV.UK One Login from using the Design System, since it's on account.gov.uk

All academic, I suspect, since the PR is approved 😁

@huwd
Copy link
Member

huwd commented Jul 2, 2024

@galund I like the GDS logo helps situate this well and perhaps distinguish from something like the service manual.

However I'm also not sure about that call on the font, I get that the quote from service manual seems clear... but in practice I'd understood it came down to site intent + if you were on a *.gov.uk domain... 🤔 might ask the senior GDS hive mind there.

I do find transport a bit clearer to read, so would like to keep it if we can.

@timblair
Copy link
Member

timblair commented Jul 2, 2024

An equally strict interpretation of the rules would prevent GOV.UK One Login from using the Design System, since it's on account.gov.uk

For use of the Design System, this is a constraint that we have placed on ourselves, that we are free to change. GDS Transport (the actual font name) has a licence agreement that restricts its legal use to a limited number of domains: [www.]gov.uk, *.service.gov.uk, and *.blog.gov.uk.

Edit: Having said that, it's actually not clear in the licence whether there are domain restrictions, and what those restrictions are if not. I've always used that blog post as the canonical position, and I'm now questioning whether it's actually correct...

Copy link
Member

@timblair timblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the logo addition (I think it's a useful addition to the clarity of the scope of the GDS Way), but I think we should park the GDS Transport change.

@timblair
Copy link
Member

timblair commented Jul 2, 2024

Actually, the service_name config entry is also used for (at least) the page <title>, so we shouldn't be adding arbitrary HTML to it. So 👍 for the idea, 👎 for the implementation.

Copy link
Member

@erino erino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the page Safari's history is The GDS Way - <span class="gds-logo">GDS</span> The GDS Way. I don't think a span can be in a title block

@galund
Copy link
Contributor Author

galund commented Jul 2, 2024

Re fonts I def feel like arguing about hypocrisy wrt the Service Manual, in the GDS Way of all places :-D ... but it's clear the implementation here is borked so will go away and re-work!

@galund galund marked this pull request as draft July 2, 2024 15:34
- to make more clear that this is by *and for* GDS

Co-authored-by: Erin Raj-Staniland <[email protected]>
@galund
Copy link
Contributor Author

galund commented Nov 15, 2024

I found the guidance which I claim fairly clearly points us to Helvetica for the content, but happy to leave for another day. https://docs.google.com/presentation/d/1qmhofgwZpGcebvl2-xsZjiEQNw5fAhEPAcI5qrnqZAs/edit#slide=id.g2c271dfb668_0_29

@galund galund marked this pull request as ready for review November 15, 2024 12:59
@galund galund requested review from erino and timblair November 18, 2024 13:04
@timblair
Copy link
Member

At a screen width where the menu is compressed to a dropdown (even though there's only one item in the menu 🤔) but the side navigation is still shown, there's an issue with the spacing between the logo and the horizontal blue bar.

Screenshot 2024-11-18 at 13 14 42

Also, should the text of the logo and the title have the same baseline, or should the title next vertically aligned with the logo box? Either way, it's not consistent between different views: when the side navigation is shown and the title text is larger, the text baselines are the same. When the side navigation isn't shown (i.e. a mobile view), and the title text is smaller, the alignment changes (although it's not obvious to what the title text is now aligning).

Screenshot 2024-11-18 at 13 18 50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants