Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go 1.18 #13

Merged
merged 4 commits into from
Sep 26, 2022
Merged

Support Go 1.18 #13

merged 4 commits into from
Sep 26, 2022

Conversation

StandoffVenus
Copy link
Contributor

Small changes that recreate types introduced in Go 1.19's atomic so that this module may support Go 1.18.

@alphadose
Copy link
Owner

@StandoffVenus instead of _ sync.Locker why not use _ noCopy where

type noCopy struct{}

@StandoffVenus
Copy link
Contributor Author

I can create and add that type - was just using sync.Locker because it already meets the no-copy check that go vet performs.

@alphadose
Copy link
Owner

@StandoffVenus yes but then you would be importing sync.Locker golang file too which would unnecessarily increase the binary size

@alphadose alphadose merged commit 9fa8085 into alphadose:main Sep 26, 2022
@StandoffVenus StandoffVenus deleted the Support-Go-1.18 branch September 26, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants