Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctest catch improvment #72

Merged
merged 5 commits into from
Jan 15, 2019
Merged

Ctest catch improvment #72

merged 5 commits into from
Jan 15, 2019

Conversation

ARMartinelli
Copy link
Member

Ctest catch improvment [#51]

@ARMartinelli ARMartinelli requested a review from mdrocco January 14, 2019 14:26
mdrocco
mdrocco requested changes Jan 14, 2019
View reviewed changes
Copy link
Member

@mdrocco mdrocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The integration looks nice, I would just consider the submodule-based approach to move all the Catch stuff into an external directory (e.g., extern/catch).

@mdrocco mdrocco mentioned this pull request Jan 15, 2019
Open
@mdrocco mdrocco merged commit 4049b21 into alpha-unito:develop Jan 15, 2019
@ARMartinelli ARMartinelli deleted the ctest_catch_improvment branch January 16, 2019 19:43
@mdrocco mdrocco mentioned this pull request Jan 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdrocco mdrocco mdrocco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ARMartinelli @mdrocco