Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Str-711: bump RETH (and deps) to the latest version. #542

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

evgenyzdanovich
Copy link
Contributor

@evgenyzdanovich evgenyzdanovich commented Dec 14, 2024

Description

Str-711: bump RETH (and deps) to the latest version. Also, fix lints.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

This is a preparation work needed to remove boa from the dependency graph. And turn cargo-audit back on.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

EDIT(@storopoli): Closes https://github.com/alpenlabs/strata/security/dependabot/12

@evgenyzdanovich evgenyzdanovich requested review from a team as code owners December 14, 2024 21:59
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 2.21239% with 663 lines in your changes missing coverage. Please review.

Project coverage is 56.13%. Comparing base (bb58728) to head (15a7bd3).

Files with missing lines Patch % Lines
crates/reth/node/src/payload_builder.rs 0.00% 142 Missing ⚠️
crates/reth/node/src/node.rs 0.00% 116 Missing ⚠️
crates/reth/rpc/src/eth/pending_block.rs 0.00% 101 Missing ⚠️
crates/reth/rpc/src/eth/mod.rs 0.00% 82 Missing ⚠️
crates/reth/rpc/src/eth/transaction.rs 0.00% 68 Missing ⚠️
crates/reth/rpc/src/eth/call.rs 0.00% 66 Missing ⚠️
crates/reth/node/src/engine.rs 0.00% 34 Missing ⚠️
crates/reth/exex/src/prover_exex.rs 0.00% 12 Missing ⚠️
crates/reth/node/src/payload.rs 0.00% 11 Missing ⚠️
crates/reth/rpc/src/eth/block.rs 0.00% 8 Missing ⚠️
... and 8 more
@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
- Coverage   56.70%   56.13%   -0.57%     
==========================================
  Files         303      301       -2     
  Lines       31000    31303     +303     
==========================================
- Hits        17577    17573       -4     
- Misses      13423    13730     +307     
Files with missing lines Coverage Δ
bin/strata-cli/src/signet/persist.rs 0.00% <ø> (ø)
crates/chaintsn/src/transition.rs 82.86% <ø> (ø)
crates/consensus-logic/src/csm/state_tracker.rs 45.60% <ø> (ø)
crates/consensus-logic/src/duty/types.rs 0.00% <ø> (ø)
crates/db/src/database.rs 74.28% <ø> (ø)
crates/db/src/traits.rs 100.00% <ø> (ø)
crates/evmexec/src/block.rs 100.00% <ø> (ø)
crates/evmexec/src/el_payload.rs 100.00% <ø> (ø)
crates/evmexec/src/engine.rs 65.67% <100.00%> (+0.14%) ⬆️
crates/evmexec/src/fork_choice_state.rs 0.00% <ø> (ø)
... and 41 more

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant