-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STR-722: refactor random generation to CryptoRngCore
#539
base: main
Are you sure you want to change the base?
Conversation
5adde85
to
5882086
Compare
The idea is to break up STR-722 into small easy-to-review PRs? |
The primary goal is to use There are a few places where we really do need |
5882086
to
4605cf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 4605cf3
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #539 +/- ##
==========================================
+ Coverage 56.56% 56.67% +0.11%
==========================================
Files 303 303
Lines 30999 31001 +2
==========================================
+ Hits 17534 17571 +37
+ Misses 13465 13430 -35
|
Description
This PR refactors the trait bound
CryptoRng + RngCore
toCryptoRngCore
fromrand_core
and performs associated import cleanup.Type of Change
Notes to Reviewers
None.
Checklist
Related Issues
None.