STR-676: updates rust nightly and sets a CI autoupdate cron job #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #537 +/- ##
==========================================
- Coverage 56.56% 56.31% -0.25%
==========================================
Files 303 303
Lines 30999 30995 -4
==========================================
- Hits 17534 17455 -79
- Misses 13465 13540 +75
|
| @@ -31,18 +31,21 @@ impl From<SequencerRpcError> for EthApiError { | |||
|
|
|||
| /// A client to interact with a Sequencer | |||
| #[derive(Debug, Clone)] | |||
| #[allow(dead_code)] // FIXME: remove this | |||
There was a problem hiding this comment.
yes, my bad :( I removed it already in the upcoming PR (bumping reth to latest)
There was a problem hiding this comment.
Ok, once we have it up we can link the PRs by adding the number here?
| @@ -85,13 +85,15 @@ impl<K: Clone + Eq + Hash, V: Clone> CacheTable<K, V> { | |||
|
|
|||
| /// Gets the number of elements in the cache. | |||
| // TODO replace this with an atomic we update after every op | |||
| #[allow(dead_code)] // FIXME: remove this | |||
There was a problem hiding this comment.
Same for this stuff, removed.
There was a problem hiding this comment.
Ok, once we have it up we can link the PRs by adding the number here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates rust nightly version and adds a CI cron job to do a PR monthly with my GH token (with very limited scope and permissions) saved in repository secrets.
Type of Change
Blocks 🪨
zizmorand harden CI jobs against malicious attackers #536 since this adds more CI stuff. It would be nice to make sure that the lints passes.[email protected]PR (number TBD)Notes to Reviewers
If you look closely, you might find a Ramanujan number hidden in this PR.
Checklist
Related Issues
STR-676