Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Str-727 Upgrade EL guest code to prove range of N blocks #533

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

MdTeach
Copy link
Contributor

@MdTeach MdTeach commented Dec 10, 2024

Description

Upgrades the current EL guest code and prover manager to support proving the range of EL blocks. The current implementation is designed to prove the STF of a single EL block. This upgrade will generalize the process to handle N blocks.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@MdTeach MdTeach changed the title Str 652 el prove range Str-652 Upgrade EL guest code to prove range of N blocks Dec 10, 2024
@MdTeach MdTeach force-pushed the STR-652-el-prove-range branch from a687b02 to 7d2602b Compare December 10, 2024 18:47
@MdTeach MdTeach marked this pull request as ready for review December 10, 2024 18:48
@MdTeach MdTeach requested review from a team as code owners December 10, 2024 18:48
@MdTeach MdTeach force-pushed the STR-652-el-prove-range branch from 7d2602b to f6b6b2c Compare December 11, 2024 05:46
@MdTeach MdTeach requested a review from a team as a code owner December 11, 2024 10:40
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 67.96117% with 33 lines in your changes missing coverage. Please review.

Project coverage is 56.64%. Comparing base (5e0edea) to head (e09cf99).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
bin/prover-client/src/proving_ops/el_ops.rs 0.00% 18 Missing ⚠️
bin/prover-client/src/prover.rs 0.00% 7 Missing ⚠️
bin/prover-client/src/proving_ops/cl_ops.rs 0.00% 2 Missing ⚠️
bin/prover-client/src/rpc_server.rs 0.00% 2 Missing ⚠️
crates/reth/exex/src/prover_exex.rs 0.00% 2 Missing ⚠️
crates/proof-impl/cl-stf/src/lib.rs 93.75% 1 Missing ⚠️
crates/proof-impl/evm-ee-stf/src/lib.rs 96.96% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
+ Coverage   56.13%   56.64%   +0.51%     
==========================================
  Files         298      304       +6     
  Lines       30530    31021     +491     
==========================================
+ Hits        17139    17573     +434     
- Misses      13391    13448      +57     
Files with missing lines Coverage Δ
crates/proof-impl/evm-ee-stf/src/db.rs 48.18% <100.00%> (ø)
crates/proof-impl/evm-ee-stf/src/primitives.rs 100.00% <100.00%> (ø)
crates/proof-impl/evm-ee-stf/src/processor.rs 61.18% <ø> (ø)
crates/proof-impl/evm-ee-stf/src/prover.rs 100.00% <100.00%> (ø)
crates/reth/db/src/rocksdb/db.rs 92.07% <100.00%> (+0.41%) ⬆️
crates/reth/rpc/src/lib.rs 0.00% <ø> (ø)
crates/rpc/prover-client-api/src/lib.rs 0.00% <ø> (ø)
crates/test-utils/src/evm_ee.rs 100.00% <100.00%> (ø)
crates/zkvm/adapters/sp1/src/host.rs 0.00% <ø> (ø)
crates/proof-impl/cl-stf/src/lib.rs 96.20% <93.75%> (-1.74%) ⬇️
... and 6 more

... and 22 files with indirect coverage changes

@MdTeach MdTeach force-pushed the STR-652-el-prove-range branch 2 times, most recently from b68ae92 to 2e0f72e Compare December 11, 2024 11:19
@MdTeach MdTeach added the prover Prover-related, extremely sensntive in production label Dec 11, 2024
@john-light john-light changed the title Str-652 Upgrade EL guest code to prove range of N blocks Str-727 Upgrade EL guest code to prove range of N blocks Dec 11, 2024
Copy link
Contributor

@delbonis delbonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

crates/proof-impl/cl-stf/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@prajwolrg prajwolrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!
While we are here let's change the names from EL -> EvmEe

@MdTeach MdTeach force-pushed the STR-652-el-prove-range branch from 2e0f72e to aa0cd3b Compare December 13, 2024 09:40
@MdTeach MdTeach force-pushed the STR-652-el-prove-range branch from aa0cd3b to 8f11872 Compare December 13, 2024 12:25
@MdTeach MdTeach force-pushed the STR-652-el-prove-range branch from 8f11872 to 0c25603 Compare December 13, 2024 12:26
Copy link
Contributor

@evgenyzdanovich evgenyzdanovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

bin/prover-client/src/proving_ops/cl_ops.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prover Prover-related, extremely sensntive in production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants