-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STR-728: Key Derivation Crate #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delbonis
reviewed
Dec 4, 2024
AaronFeickert
requested changes
Dec 6, 2024
AaronFeickert
requested changes
Dec 10, 2024
delbonis
previously requested changes
Dec 10, 2024
john-light
changed the title
STR-470: Key Derivation Crate
STR-728: Key Derivation Crate
Dec 11, 2024
AaronFeickert
requested changes
Dec 11, 2024
Signed-off-by: Jose Storopoli <[email protected]>
Signed-off-by: Jose Storopoli <[email protected]>
Signed-off-by: Jose Storopoli <[email protected]>
Signed-off-by: Jose Storopoli <[email protected]>
Signed-off-by: Jose Storopoli <[email protected]>
good comments! |
AaronFeickert
requested changes
Dec 12, 2024
AaronFeickert
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
delbonis
approved these changes
Dec 12, 2024
Rajil1213
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the Key Derivation Library Crate.
TODO
Zeroize
/ZeroizeOnDrop
bridge-client
CLI to use the key derivation crate.datatool
to usekey-derivation
crate.Type of Change
Notes to Reviewers
The key derivation crate moves the logic of key derivation away from the bridge and sequencer binaries into a separate standalone crate.
This will be equipped with proper tests and error types.
Checklist
Related Issues
STR-728