-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi shipping insurance compatibility #208
Multi shipping insurance compatibility #208
Conversation
Update Aqua workflow with trivy-db fix
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
You could probably refactor the setup code of your tests into a single utility function, but not a blocker IMHO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve not to block, but yes, if you could rebase next time to avoid this :D
Thanks !
@olance How do you see the refactoring of the setup? |
Reason for change
Code based on Main branches not devellop for Zip to marketplace
Linear task
Code changes
Change observer order management in array for multi shipping.
$order -> [$order]
for multi shipping we receive [$order1, $order2]
How to test
Test multi shippping in magento 2
As a reviewer, you are encouraged to test the PR locally.
Checklist for authors and reviewers
Non applicable