Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle configuration module to save and display the form #608

Open
wants to merge 11 commits into
base: feature/ecom-2150-ps-refactor-controller-getcontent
Choose a base branch
from

Conversation

Benjamin-Freoua-Alma
Copy link
Member

Reason for change

Linear task

Code changes

Refacto the controller GetContent to display and save the form configuration o our module

How to test

As a reviewer, you are encouraged to test the PR locally.

  • Use unit test
  • Test the configuration form of our module, save, display, change configuration, without api key, with wrong api key...

Checklist for authors and reviewers

  • The title of the PR uses business wording, not technical jargon, for the changelog readers to understand it
  • The PR implements the changes asked in the referenced task / issue
  • The automated tests are compliant with the testing strategy
  • The tests are relevant, and cover the corner/error cases, not only the happy path
  • You understand the impact of this PR on existing code/features
  • The changes include adequate logging and Datadog traces
  • Documentation is updated (API, developer documentation, ADR, Notion...)

Non applicable

@Benjamin-Freoua-Alma Benjamin-Freoua-Alma force-pushed the feature/ecom-2244-ps-handle-configuration-module-to-save-and-display-the-form branch from d646c61 to 6d8ccce Compare December 2, 2024 15:06
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma marked this pull request as ready for review December 10, 2024 16:10
@Benjamin-Freoua-Alma Benjamin-Freoua-Alma requested a review from a team as a code owner December 10, 2024 16:10
Copy link
Contributor

@joyet-simon joyet-simon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test result:
image
I try to debug it

Copy link

sonarcloud bot commented Dec 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
26.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants