Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'Severity' translatable #2396

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

noomorph
Copy link
Contributor

@noomorph noomorph commented Mar 5, 2024

Context

Makes it possible to use i18n keys for five allowed severity types: blocker, critical, normal, minor, trivial.

Adds initial translation values for English, Interslavic, Polish, and Russian.

English Interslavic Russian Polish
English Interslavic Russian Polish

Checklist

@noomorph
Copy link
Contributor Author

noomorph commented Mar 5, 2024

Question

Could you please advise on whether it is recommended to associate the adjective with the Severity or with the Test? For example, should it be Важность: критическая or Важность: критический?

Other translations

I have an AI-generated translation table, but I'm unsure if incorporating it is wise. Maybe humans would do a better job gradually.

Language (Code) Severity Term Blocker Critical Normal Minor Trivial
English (en) Severity Blocker Critical Normal Minor Trivial
Azerbaijani (az) Əhəmiyyət Bloker Kritik Normal Kiçik Əhəmiyyətsiz
Brazilian Portuguese (br) Severidade Bloqueador Crítico Normal Menor Trivial
German (de) Schweregrad Blockierend Kritisch Normal Geringfügig Unwesentlich
Spanish (es) Severidad Bloqueante Crítico Normal Menor Trivial
French (fr) Sévérité Bloquant Critique Normal Mineur Trivial
Hebrew (he) חומרה חוסם קריטי רגיל קל שולי
Japanese (ja) 重要度 ブロッカー クリティカル ノーマル マイナー 些細な
Korean (kr) 중요도 차단 중대한 보통 경미한 사소한
Dutch (nl) Ernst Blokkerend Kritiek Normaal Klein Triviaal
Turkish (tr) Önem Engelleyici Kritik Normal Küçük Önemsiz
Chinese (Simplified) (zh) 严重性 阻塞 严重 普通 轻微 微不足道

@noomorph

This comment was marked as resolved.

Copy link
Member

@baev baev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only speak Java, so can't review the translations

@baev baev added the type:improvement Change that improves some user experience but can't be considered as a new feature label Mar 12, 2024
@epszaw
Copy link
Member

epszaw commented Mar 13, 2024

@noomorph let's keep the PR as is. I'll do a review as soon as it is possible

@noomorph noomorph requested a review from epszaw March 13, 2024 15:56
@baev baev merged commit a59f8f1 into allure-framework:main Mar 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:ui type:improvement Change that improves some user experience but can't be considered as a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants