Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] We need a major version bump due to #1292 being a breaking change #1307

Closed
iajoiner opened this issue Sep 18, 2024 · 1 comment
Closed

[Bug] We need a major version bump due to #1292 being a breaking change #1307

iajoiner opened this issue Sep 18, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@iajoiner
Copy link

iajoiner commented Sep 18, 2024 •
edited
Loading

Component

other

What version of Alloy are you on?

0.3.6

Operating System

Linux

Describe the bug

#1292 is a breaking change since it adds a new enum variant without non-exhaustive (see https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new). This broke revm-inspectors and in turn foundry and proof-of-sql which I work on (see https://github.com/spaceandtimelabs/sxt-proof-of-sql/actions/runs/10927271217/job/30333055842?pr=166). It is probably a good idea to yank 0.3.6 and re-release it as 0.4.0 or more projects will be affected.
@iajoiner iajoiner added the bug Something isn't working label Sep 18, 2024
@iajoiner iajoiner changed the title [Bug] We need a major version bump due to https://github.com/alloy-rs/alloy/issues/1292 [Bug] We need a major version bump due to #1292 being a breaking change Sep 18, 2024
This was referenced Sep 18, 2024
Closed
Merged
JayWhite2357 added a commit to spaceandtimelabs/sxt-proof-of-sql that referenced this issue Sep 18, 2024
@JayWhite2357
fix: temporarily disable solidity tests (#166)
44e9e98 
# Rationale for this change
See alloy-rs/alloy#1307 and
foundry-rs/foundry#8895 for the background.

# What changes are included in this PR?
Disable solidity tests

# Are these changes tested?
Existing tests do pass
@iajoiner iajoiner mentioned this issue Sep 19, 2024
Open
@mattsse
Copy link
Member

mattsse commented Nov 6, 2024

sorry about this, we'll be more careful moving forward

@mattsse mattsse closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iajoiner @mattsse