-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIP-11] Allow round creation via Registry #19
Conversation
Based off the discussion off https://github.com/orgs/allo-protocol/discussions/8
The project struct already has the metadata pointer, so do you mean just rename it from metadata to projectMetadata? |
The registry already has this function:
|
The even already has the metadata type in the pointer
|
@gravityblast Since a second metapointer is introduced, a new function for the second metapointer is added. To simplify the implementation, a single event is used when updating a metapointer. To distinguish between the two metapointers, a type (enum) is introduced, indicating whether the updated metapointer corresponds to the Project or Program metapointer. |
I don't think it makes sense to have It makes sense to have a different mapping with |
@KurtMerbeth ok so we should update the document because now it says:
so maybe they need to be renamed to "update Program metadata"? |
@gravityblast You are right. I had confused the name while writing the AIP. |
nice thank you @thelostone-mc ! ❤️ |
Based off the discussion off : https://github.com/orgs/allo-protocol/discussions/8
PR : #19