Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ledger.md to add asset close amount field #34

Merged
merged 4 commits into from
Feb 3, 2021
Merged

Update ledger.md to add asset close amount field #34

merged 4 commits into from
Feb 3, 2021

Conversation

algorotem
Copy link
Contributor

No description provided.

@algorotem algorotem mentioned this pull request Feb 2, 2021
Merged
zeldovich
zeldovich suggested changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@zeldovich zeldovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe your change modifies the asset transfer transaction, but my guess is you wanted to add this extra field to ApplyData. What would be the semantics of closing an account where the closing transaction has the wrong closing amount?

@algorotem
Copy link
Contributor Author

algorotem commented Feb 2, 2021 •
edited
Loading

I believe your change modifies the asset transfer transaction, but my guess is you wanted to add this extra field to ApplyData. What would be the semantics of closing an account where the closing transaction has the wrong closing amount?

I'm probably missing something about the relationship of the implementation and the spec. The ApplyData is not part of the transaction but we are storing it in the block. Should we not modify the spec then?

--- Edit
Just realized it's the wrong location. pushing an edit right now

@tsachiherman
Copy link
Contributor

tsachiherman commented Feb 2, 2021 •
edited
Loading

The corresponding PR on the go-algorand repo is this : algorand/go-algorand#1886
consensus upgrade on the go-algorand repo is at : algorand/go-algorand#1888

@algofoundation algofoundation merged commit bea1928 into algorandfoundation:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeldovich zeldovich zeldovich requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@algorotem @tsachiherman @zeldovich @algofoundation