Fix: Pass args to underlying kmd_request function, including timeout
#545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpaulos
changed the title
kmd_request function, including timeoutkmd_request function, including timeout
algorandskiy
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#527 introduced a default timeout of 30s for KMD, algod, and indexer requests.
Algod and indexer use kwargs to pass extra arguments to their underlying
algod_request&indexer_requestfunctions, includingtimeout.Unfortunately KMD had no such functionality, so it's impossible to change the default 30s timeout. This PR adds kwargs to all KMD functions to forward parameters like
timeouttokmd_request.