Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Support updated simulate endpoint #466

Merged
merged 5 commits into from
Apr 19, 2023
Merged

API: Support updated simulate endpoint #466

merged 5 commits into from
Apr 19, 2023

Conversation

jasonpaulos
Copy link
Contributor

Support the changes to simulate from algorand/go-algorand#5292

jasonpaulos
jasonpaulos commented Apr 14, 2023
View reviewed changes
.test-env Outdated Show resolved Hide resolved
@ahangsu ahangsu self-requested a review April 14, 2023 17:58
@jasonpaulos jasonpaulos marked this pull request as ready for review April 18, 2023 21:47
@bbroder-algo
Copy link
Contributor

interesting that who does the post flips but it all makes sense.
This is a breaking change.

bbroder-algo
bbroder-algo approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@bbroder-algo bbroder-algo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contingent on ahangsu

ahangsu
ahangsu approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@ahangsu ahangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookin fine to me

@jasonpaulos jasonpaulos merged commit c1120d5 into develop Apr 19, 2023
@jasonpaulos jasonpaulos deleted the updated-simulate branch April 19, 2023 22:01
@algobarb algobarb mentioned this pull request May 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbroder-algo bbroder-algo bbroder-algo approved these changes

@ahangsu ahangsu ahangsu approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonpaulos @bbroder-algo @ahangsu