bugfix: fix msig sks type + a couple other mypy complaints

algosdk/atomic_transaction_composer.py

@@ -679,7 +679,7 @@ class MultisigTransactionSigner(TransactionSigner):
         sks (str): private keys of multisig
     """
 
-    def __init__(self, msig: transaction.Multisig, sks: str) -> None:
+    def __init__(self, msig: transaction.Multisig, sks: List[str]) -> None:
         super().__init__()
         self.msig = msig
         self.sks = sks

algosdk/dryrun_results.py

@@ -1,5 +1,5 @@
 import base64
-from typing import List, Optional, cast
+from typing import List, Optional, cast, Dict, Any
 
 
 class StackPrinterConfig:
@@ -26,15 +26,15 @@ def __init__(self, drrjson: dict):
 
 
 class DryrunTransactionResult:
-    def __init__(self, dr):
+    def __init__(self, dr: Dict[str, Any]):
         assert (
             "disassembly" in dr
         ), "expecting dryrun transaction result to have key 'disassembly' but its missing"
 
         self.disassembly = dr["disassembly"]
 
         # cost is separated into 2 fields: `budget-added` and `budget-consumed`
-        optionals = [
+        optionals: List[str] = [
             "app-call-messages",
             "local-deltas",
             "global-delta",
@@ -45,7 +45,7 @@ def __init__(self, dr):
             "logs",
         ]
 
-        def attrname(field):
+        def attrname(field: str):
             return field.replace("-", "_")
 
         for field in optionals:
@@ -131,7 +131,7 @@ def app_trace(self, spc: Optional[StackPrinterConfig] = None) -> str:
             spc = StackPrinterConfig(top_of_stack_first=False)
         spc = cast(StackPrinterConfig, spc)
 
-        return self.trace(self.app_call_trace, self.disassembly, spc=spc)
+        return self.trace(self.app_call_trace, self.disassembly, spc=spc)  # type: ignore[attr-defined]  # dynamic attribute
 
     def lsig_trace(self, spc: Optional[StackPrinterConfig] = None) -> str:
         if not hasattr(self, "logic_sig_trace"):
@@ -181,6 +181,7 @@ def __str__(self) -> str:
         return str(self.int)
 
     def __eq__(self, other: object):
+        other = cast(DryrunStackValue, other)
         return (
             hasattr(other, "type")
             and self.type == other.type

mypy.ini

@@ -1 +1,5 @@
 [mypy]
+
+
+[mypy-msgpack.*]
+ignore_missing_imports = True