Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix test across Python versions for unit tests #325

Merged
merged 5 commits into from
Apr 28, 2022

Conversation

michaeldiamant
Copy link
Contributor

Follows #323 to unit test Python 3.8, 3.9, and 3.10 in order to improve confidence that changes work across Python versions.

Details:

Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the matrix also test the docset?

Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaeldiamant
Copy link
Contributor Author

Should the matrix also test the docset?

@algochoi I left docset as is because I assumed library consumers do not generate docs. Is it a fair assumption?

@algochoi
Copy link
Contributor

Should the matrix also test the docset?

@algochoi I left docset as is because I assumed library consumers do not generate docs. Is it a fair assumption?

The assumption sounds okay to me - sometimes I build the docs locally, but I don't really see it as a blocker or whether it would affect this.

@jasonpaulos
Copy link
Contributor

jasonpaulos commented Apr 27, 2022

This looks good as is, but extra effort is needed to make cucumber tests run with the appropriate Python version. Currently our Dockerfile runs all cucumber tests in Python 3.7.9:

FROM python:3.7.9

A while ago I made this PR to the Go SDK to achieve the same thing using Docker build args: algorand/go-algorand-sdk#228

@michaeldiamant
Copy link
Contributor Author

Currently our Dockerfile runs all cucumber tests in Python 3.7.9:

@jasonpaulos A few notes:

Base automatically changed from bump_to_python38 to develop April 28, 2022 17:24
@michaeldiamant
Copy link
Contributor Author

Merging - I welcome further feedback and will open a new PR should we agree to further changes.

@michaeldiamant michaeldiamant merged commit d79c1c1 into develop Apr 28, 2022
@michaeldiamant michaeldiamant deleted the matrix_test_python_versions branch April 28, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants