-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matrix test across Python versions for unit tests #325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the matrix also test the docset
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@algochoi I left |
The assumption sounds okay to me - sometimes I build the docs locally, but I don't really see it as a blocker or whether it would affect this. |
This looks good as is, but extra effort is needed to make cucumber tests run with the appropriate Python version. Currently our Line 1 in ed15008
A while ago I made this PR to the Go SDK to achieve the same thing using Docker build args: algorand/go-algorand-sdk#228 |
@jasonpaulos A few notes:
|
Merging - I welcome further feedback and will open a new PR should we agree to further changes. |
Follows #323 to unit test Python 3.8, 3.9, and 3.10 in order to improve confidence that changes work across Python versions.
Details:
integration-test
machine image (ubuntu-2004:202104-01
) runs the targeted minimum Python version (3.8) by checking https://circleci.com/docs/2.0/configuration-reference/#machine.