C2C Feature and Testing #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o it can pass these tests
tzaffi
commented
Jan 18, 2022
tzaffi
commented
Jan 19, 2022
| @@ -1,27 +1,31 @@ | |||
| # py-algorand-sdk | |||
There was a problem hiding this comment.
markdownlint'ing this file
jasonpaulos
approved these changes
Jan 21, 2022
algochoi
approved these changes
Jan 21, 2022
| local_bytes=None, | ||
| local_ints=None, | ||
| extra_pages=None, | ||
| force_unique_transactions=False, |
tzaffi
commented
Jan 31, 2022
a -> an and trigger new tests!
tzaffi
commented
Jan 31, 2022
remove period and trigger new test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling Contract to Contract Applications in the SDK
This PR aims to show that the critical capabilities for handling C2C functionality are in place. This is accomplished by implementing and passing Cucumber integration tests that are defined in
algorand-sdk-testingPR #156.New Functionality
Slight Enhancement to Function Obtaining Application Account Address
In a Contract-to-Contract call, the application that is making the call is responsible for paying the associated transaction fees. This means that the application needs to be funded and that its account address should be readily available for funding.
logicalready containsget_application_address(), and I'm just adding a type-checker for it.Add void ABI Method
applTransactions into theList[ABIResult]Member ofAtomicTransactionResponseThis is mainly for completeness when trying to understand all trasactions (including nested) and all side-effects that resulted from ABI method calls in an atomic transactions group.
New Cucumber Tests
To pass the tests in testing's PR #156 (and mainly
integration/c2s.feature) functions have been refactored with new steps added inside oftest/steps/Transaction call trace from an Atomic Transaction Composer ABI Execution
Allow json-like traces of ABI calls via
transactions_trace(atc: AtomicTransactionComposer, results: List[ABIResult])inv2_steps.pySummary of changes
Makefile: re-org the cucumber tags into variables for easier running of selected testsalgosdk/atomic_transaction_composer.py: adding non-void ABI methodappltransactions to theABIResults inside of anAtomicTransactionResponsealgosdk/future/template.py: deprecation comments addedalgosdk/logic.py: type assertion forget_application_address(appID: int)algosdk/v2client/algod.py: re-org'ed the imports ONLYrequirements.txt: addedglomandpytesetwhich are needed for testing (but not any running code)run_integration.sh: temporarily pointing to C2C sdk-testing branchtest/environment.py: small bugfixtest/steps/__init__.py: helped me run my tests locally in a debuggertest/steps/steps.py: removeTemplatesrelated stepstest/steps/v2_steps.py: modifications for passing the cucumber teststest_unit.py:Templatesrelated unit testsLinks