FOR REVIEW ONLY - py-algorand-sdk v1.9.0b1 #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add initial support for ABI types * Finish up abi types and values * Add doc strings * Refactor and finish encoding functions * More cleanup * Fix minor bugs and add number decoding * Bump version to 1.8.0 and add changelog * Add change to changelog * Add decoding for arrays and dynamic types * Add more unit tests * Minor change from PR comment * Another small PR comment change * Split up files and remove circular imports * Address PR comments * Have arrays accept bytes and add docstrings * Minor clean up * Fix error messages for negative uint * Remove unnecessary imports * Refactor out abi_types since it is implicit by the class * Tuples don't need static lengths... * Address PR comments 1 * Fix head encoding placeholders * Fix the tuple docstring * Formatting fixes Co-authored-by: Brice Rising <[email protected]>
* Add circle ci configs * Formatting * Update image
* Start ABI JSON interaction * Add static annoation * Fix Method argument parsing * Add ABI Typing to Method arguments * [WIP] Add AtomicTransactionComposer build functions * [WIP] Sign and send atomic transaction groups * Add unit tests for object parsing * Clean up method calls * Address PR comments on JSON objects * Refactor ABI Type to ABIType so it can be exposed to outside world * Add cucumber steps for ABI tests and update existing implementation so it can pass these tests * Refactor TransactionSigner to Abstract class and merge signatures when signing * Update testing to reflect json unit tests and composer tests * Formatting and docstring fixes * Clean up imports * Fix unit test for appId * Refactor some names and add txn as an arg type * Partially address PR comments * Add some additional checks for safety * Fix a step so we check for empty string instead of None * MInclude returns tests and check for a valid returns from a ABI call * Addressing PR comments about type hints and returning self * Ensure group ids are zero when adding transactions
* Add type hints and clean up ABI types * Change relative imports to absolute imports * Add type hints for ABI objects * Refactor composer with type hints * Address PR comments, change list type hints, and move type_from_string to ABIType
onetechnical
requested review from
jasonpaulos,
egieseke,
bricerisingalgorand,
algobarb and
algojack
jasonpaulos
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
1.9.0b1
Added