Break out cucumber tags into their own files #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzaffi
commented
Aug 18, 2022
| @compile | ||
| @compile.sourcemap | ||
| @dryrun | ||
| @kmd |
There was a problem hiding this comment.
3 @indexer* integration tags have also been removed
michaeldiamant
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
@tzaffi Thanks for bringing the tag separation to js-algorand-sdk.
Merging to resolve parent PR thread.
algochoi
added a commit
that referenced
this pull request
Aug 22, 2022
…623) * Add files to enable sandbox sdk testing * Add some todo comments and formatting * Update changes to script and env * Delete indexer v1 test steps * More changes to cucumber tests * Change features directory in JS SDK * Remove more indexer integration tests * Update test env * Update test-harness.sh Co-authored-by: Zeph Grunschlag <[email protected]> * Break out cucumber tags into their own files (#625) * Command to generate input for Unused Steps Analysis Script + Remove those steps (#627) * command to generate input for Unused Steps Analysis Script + Remove those steps * remvoe the steps * In response to CR remark. Update Makefile * Update .test-env Co-authored-by: Zeph Grunschlag <[email protected]> Co-authored-by: Zeph Grunschlag <[email protected]>
ahangsu
added a commit
that referenced
this pull request
Sep 3, 2022
* bump version and add to changelog * update README.md for new version * prettier on CHANGELOG * Update README.md Co-authored-by: John Lee <[email protected]> * Update README.md Co-authored-by: John Lee <[email protected]> * Enhancement: Use sandbox for SDK Testing and remove Indexer v1 steps (#623) * Add files to enable sandbox sdk testing * Add some todo comments and formatting * Update changes to script and env * Delete indexer v1 test steps * More changes to cucumber tests * Change features directory in JS SDK * Remove more indexer integration tests * Update test env * Update test-harness.sh Co-authored-by: Zeph Grunschlag <[email protected]> * Break out cucumber tags into their own files (#625) * Command to generate input for Unused Steps Analysis Script + Remove those steps (#627) * command to generate input for Unused Steps Analysis Script + Remove those steps * remvoe the steps * In response to CR remark. Update Makefile * Update .test-env Co-authored-by: Zeph Grunschlag <[email protected]> Co-authored-by: Zeph Grunschlag <[email protected]> * Bugfix: Pass verbosity to the harness and sandbox (#630) * Ignore algorand-sdk-testing test-harness dir (#634) * Enhancement: Deprecating use of langspec (#632) * enhancement: Initial stateproofs support (#629) * Initial stateproofs support * Some more unused steps (#637) * dummy push * revert change of dummy push, ci runs now Co-authored-by: Barbara Poon <[email protected]> Co-authored-by: algobarb <[email protected]> Co-authored-by: John Lee <[email protected]> Co-authored-by: algochoi <[email protected]> Co-authored-by: Zeph Grunschlag <[email protected]> Co-authored-by: Michael Diamant <[email protected]> Co-authored-by: Eric Warehime <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking out tags under
tests/cucumber/unit.tagstests/cucumber/integration.tagsfor more human readable diffs and also to conform with the other SDK's